- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
SSR functional full network #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Patch Fea3 PCC: 0.9878828566413058 cleanup
…onfig Adds license comment in CAB __init__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a README that includes a brief intro to the model.
instructions to set up the proper env to run pytests and the command to run them and what each test does.
also include the device and end to perf numbers in the README. use this as an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 
           Hi @mbezuljTT, Could you please review the PR?  | 
    
What's changed
Added TT implementation of Selective Super Resolution (SSR) model in
tt-metal.Results
PCC Score
Hardware: Wormhole n150:
Note
Code refactoring and optimisation are still in progress.
Torch Fallback usage in code
Tensor unpadding (
window_attn_tr.py,OCAB.py):ttnn.transformeroperation requirement:Head size must be a multiple of 32.ttnn.transformeroperations.ttnn.transformeroperations is unpaded.Pixel Shuffle Optimization (
upsample.py):torch.nn.functional.pixel_shuffleinstead of manual reshapes and permute operations.Bicubic Upsample (
ssr.py):Approximation with ttnn upsample with mode as bilinear was resulting in lower pcc.
Window Reverse (
test_ssr.py):Checklist