[WIP] simplify readonly types

libs/sanctum-stake-lib/src/account_resolvers/authorize.rs

@@ -31,8 +31,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> AuthorizeFreeAccounts<S> {
         authority_getter: fn(&StakeOrInitializedStakeAccount<&'a S>) -> Pubkey,
     ) -> Result<AuthorizeFreeKeys, ProgramError> {
         let Self { stake } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         let authority = authority_getter(&s);
         Ok(AuthorizeFreeKeys {

libs/sanctum-stake-lib/src/account_resolvers/authorize_checked.rs

@@ -60,8 +60,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> AuthorizeCheckedFreeAccount
             stake,
             new_authority,
         } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         Ok(AuthorizeCheckedFreeKeys {
             stake: *stake.pubkey(),

libs/sanctum-stake-lib/src/account_resolvers/deactivate.rs

@@ -16,8 +16,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> DeactivateFreeAccounts<S> {
 
     pub fn resolve_to_free_keys(&self) -> Result<DeactivateFreeKeys, ProgramError> {
         let Self { stake } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         let stake_authority = s.stake_meta_authorized_staker();
         Ok(DeactivateFreeKeys {

libs/sanctum-stake-lib/src/account_resolvers/deactivate_delinquent.rs

@@ -16,8 +16,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> DeactivateDelinquentFreeAcc
             stake,
             reference_vote,
         } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake()?;
         Ok(DeactivateDelinquentKeys {
             stake: *stake.pubkey(),

libs/sanctum-stake-lib/src/account_resolvers/delegate_stake.rs

@@ -17,8 +17,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> DelegateStakeFreeAccounts<S
 
     pub fn resolve_to_free_keys(&self) -> Result<DelegateStakeFreeKeys, ProgramError> {
         let Self { stake, vote } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         Ok(DelegateStakeFreeKeys {
             stake: *stake.pubkey(),

libs/sanctum-stake-lib/src/account_resolvers/merge.rs

@@ -7,8 +7,7 @@ use stake_program_interface::MergeKeys;
 use crate::ReadonlyStakeAccount;
 
 fn read_stake_authority_checked<T: ReadonlyAccountData>(stake: T) -> Result<Pubkey, ProgramError> {
-    let s = ReadonlyStakeAccount(stake);
-    let s = s.try_into_valid()?;
+    let s = ReadonlyStakeAccount::try_new(stake)?;
     let s = s.try_into_stake_or_initialized()?;
     Ok(s.stake_meta_authorized_staker())
 }

libs/sanctum-stake-lib/src/account_resolvers/redelegate.rs

@@ -18,8 +18,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> RedelegateFreeAccounts<S> {
             uninitialized_stake,
             vote,
         } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         Ok(RedelegateFreeKeys {
             stake: *stake.pubkey(),

libs/sanctum-stake-lib/src/account_resolvers/set_lockup.rs

@@ -61,8 +61,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> SetLockupFreeAccounts<S> {
         getter: fn(&StakeOrInitializedStakeAccount<&'a S>) -> Pubkey,
     ) -> Result<Pubkey, ProgramError> {
         let Self { stake } = self;
-        let s = ReadonlyStakeAccount(stake);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(stake)?;
         let s = s.try_into_stake_or_initialized()?;
         Ok(getter(&s))
     }

libs/sanctum-stake-lib/src/account_resolvers/split.rs

@@ -13,8 +13,7 @@ pub struct SplitFreeAccounts<S> {
 impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> SplitFreeAccounts<S> {
     pub fn resolve(&self) -> Result<SplitKeys, ProgramError> {
         let Self { from, to } = self;
-        let s = ReadonlyStakeAccount(from);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(from)?;
         let s = s.try_into_stake_or_initialized()?;
         Ok(SplitKeys {
             from: *from.pubkey(),

libs/sanctum-stake-lib/src/account_resolvers/withdraw.rs

@@ -17,8 +17,7 @@ impl<S: ReadonlyAccountData + ReadonlyAccountPubkey> WithdrawFreeAccounts<S> {
 
     pub fn resolve_to_free_keys(&self) -> Result<WithdrawFreeKeys, ProgramError> {
         let Self { from, to } = self;
-        let s = ReadonlyStakeAccount(from);
-        let s = s.try_into_valid()?;
+        let s = ReadonlyStakeAccount::try_new(from)?;
         let s = s.try_into_stake_or_initialized()?;
         let withdraw_authority = s.stake_meta_authorized_withdrawer();
         Ok(WithdrawFreeKeys {