Skip to content

Fix: deposit stake quote wrong #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix: deposit stake quote wrong #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52a4d09
update picosol test fixture to fail deposit stake test
billythedummy Jun 7, 2025
0820304
WIP, still failing because all stake accounts are activating, not active
billythedummy Jun 7, 2025
e2b9fb9
wip stash
billythedummy Jun 12, 2025
ea15e87
Merge branch 'master' into fix/deposit-stake-quote-wrong
billythedummy Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"[json]": {
"editor.tabSize": 2
},
"[markdown]": {
"editor.tabSize": 2
},
"[jsonc]": {
"editor.tabSize": 2
},
Expand Down
12 changes: 10 additions & 2 deletions test-fixtures/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ For example, `signer-picosol-token-deposit-sol.json` is a picoSOL spl token acco

This can be achieved from existing accounts by editing their raw bytes, re-encoding it to base64 and updating the test-fixtures json account file.

## Stake Pools
## Accounts Notes

- picosol stake pool data collected at epoch 787
- `deposit-stake` activation epoch changed to 0 so that its fully active for the test
- picosol stake pool data collected at epoch 787:
- fee settings (changes made to make sure we cover different test cases):
- epoch fee unchanged at 25/1000
- stake deposit fee changed from 0/100 to 1/10000
- stake withdrawal fee unchanged at 1/1000
- sol deposit fee changed from 0/100 to 1/5000
- vsa activation epoch changed to 0 so that its fully active for the test
- changed last update epoch of all involved accounts (pool, validator list) to 1
2 changes: 1 addition & 1 deletion test-fixtures/picosol-stake-pool.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"account": {
"lamports": 5143440,
"data": [
"AeVDKQDgR3b61MLyI/oLdrrL9Abi0e7jN26ks177tp6ExQjOg16DNnSQKoMqmj2/NbsP0yqUGoDATiPGdH6HT4KSQBHMTxJqGt9Z8+ORKewb19QVkqDpmyC3QqkDmDRxCv8t5Tm1+cZsprYaE3+egWRprk+31+48NcEavkLmlyQ1YRFiOkYy7RYkBC3+47A0IrgZz5ZrFiihNiA17wgE/absDDla18UNF/qu18wub6yLB67QePPJIe4KC0uEXwsh6kI5ZmJ62eWx/bMWl36EF6dM6UVvW7dxm4maOrezvmfQnQbd9uHXZaGT2cvhRs7reawctIXtX1s3kTqM9YV+/wCp7/XRkmG/AACrnGkYkqoAABMDAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA6AMAAAAAAAAZAAAAAAAAAAAAAGQAAAAAAAAAAAAAAAAAAADoAwAAAAAAAAEAAAAAAAAAAAAAZAAAAAAAAAAAAAAAAAAAAAAA6AMAAAAAAAABAAAAAAAAAACL2ZLJ3KsAABniBCm+wAAAAwAAAAAAAAEAAAAAAAAAAMwRPvHTQAAAF+4OSqNHAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=",
"AeVDKQDgR3b61MLyI/oLdrrL9Abi0e7jN26ks177tp6ExQjOg16DNnSQKoMqmj2/NbsP0yqUGoDATiPGdH6HT4KSQBHMTxJqGt9Z8+ORKewb19QVkqDpmyC3QqkDmDRxCv8t5Tm1+cZsprYaE3+egWRprk+31+48NcEavkLmlyQ1YRFiOkYy7RYkBC3+47A0IrgZz5ZrFiihNiA17wgE/absDDla18UNF/qu18wub6yLB67QePPJIe4KC0uEXwsh6kI5ZmJ62eWx/bMWl36EF6dM6UVvW7dxm4maOrezvmfQnQbd9uHXZaGT2cvhRs7reawctIXtX1s3kTqM9YV+/wCp7/XRkmG/AACrnGkYkqoAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA6AMAAAAAAAAZAAAAAAAAAAAAABAnAAAAAAAAAQAAAAAAAADoAwAAAAAAAAEAAAAAAAAAAAAAiBMAAAAAAAABAAAAAAAAAAAA6AMAAAAAAAABAAAAAAAAAACL2ZLJ3KsAABniBCm+wAAAAwAAAAAAAAEAAAAAAAAAAMwRPvHTQAAAF+4OSqNHAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=",
"base64"
],
"owner": "SP12tWFxD9oJsVWNavTTBZvMbA6gkAmxtVgxdqvyvhY",
Expand Down
2 changes: 1 addition & 1 deletion test-fixtures/picosol-validator-list.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"account": {
"lamports": 1461600,
"data": [
"AgEAAAABAAAAEC5/kmG/AAAAAAAAAAAAABMDAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAr/o4HzxQmLUK+tRO1dlVCzPlSnj37G65EkaSDFVRdow==",
"AgEAAAABAAAAEC5/kmG/AAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAr/o4HzxQmLUK+tRO1dlVCzPlSnj37G65EkaSDFVRdow==",
"base64"
],
"owner": "SP12tWFxD9oJsVWNavTTBZvMbA6gkAmxtVgxdqvyvhY",
Expand Down
2 changes: 1 addition & 1 deletion test-fixtures/picosol-validator-stake.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"account": {
"lamports": 210442783116351,
"data": [
"AgAAAIDVIgAAAAAALxsbDTisADc8y4cG2VUTzCo1qiLNEnkT4pFibQMyRfovGxsNOKwANzzLhwbZVRPMKjWqIs0SeRPikWJtAzJF+gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACv+jgfPFCYtQr61E7V2VULM+VKePfsbrkSRpIMVVF2jkFhckmG/AABMAgAAAAAAAP//////////AAAAAAAA0D8pMnElAAAAAAAAAAA=",
"AgAAAIDVIgAAAAAALxsbDTisADc8y4cG2VUTzCo1qiLNEnkT4pFibQMyRfovGxsNOKwANzzLhwbZVRPMKjWqIs0SeRPikWJtAzJF+gAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACv+jgfPFCYtQr61E7V2VULM+VKePfsbrkSRpIMVVF2jkFhckmG/AAAAAAAAAAAAAP//////////AAAAAAAA0D8pMnElAAAAAAAAAAA=",
"base64"
],
"owner": "Stake11111111111111111111111111111111111111",
Expand Down