Skip to content

fix: fix CCA repositoryUrl for registry#191

Merged
julienrbrt merged 1 commit intomainfrom
fix/registry-github-url
Apr 9, 2025
Merged

fix: fix CCA repositoryUrl for registry#191
julienrbrt merged 1 commit intomainfrom
fix/registry-github-url

Conversation

@Pantani
Copy link
Collaborator

@Pantani Pantani commented Apr 9, 2025

No description provided.

@Pantani Pantani self-assigned this Apr 9, 2025
@github-actions github-actions bot added the ci label Apr 9, 2025
julienrbrt
julienrbrt previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but we need to make sure it doesn't break the installations instructions on the website

@Pantani
Copy link
Collaborator Author

Pantani commented Apr 9, 2025

Makes sense to me, but we need to make sure it doesn't break the installations instructions on the website

Yes, I think so, wdyt about have an appUrl and repoURL?

@julienrbrt
Copy link
Member

julienrbrt commented Apr 9, 2025

Makes sense to me, but we need to make sure it doesn't break the installations instructions on the website

Yes, I think so, wdyt about have an appUrl and repoURL?

Aren't we able to add that /tree/main manually when we need it?

@Pantani Pantani force-pushed the fix/registry-github-url branch from 39da315 to 7047f30 Compare April 9, 2025 14:21
@Pantani Pantani changed the title fix: add the full app path url to repositoryUrl registry field fix: fix CCA repositoryUrl for registry Apr 9, 2025
@Pantani
Copy link
Collaborator Author

Pantani commented Apr 9, 2025

Makes sense to me, but we need to make sure it doesn't break the installations instructions on the website

Yes, I think so, wdyt about have an appUrl and repoURL?

Aren't we able to add that /tree/main manually when we need it?

yeap, we can do it, I change this PR to fix only the CCA path

@Pantani Pantani requested a review from julienrbrt April 9, 2025 14:22
@julienrbrt julienrbrt merged commit 583ca3b into main Apr 9, 2025
23 checks passed
@julienrbrt julienrbrt deleted the fix/registry-github-url branch April 9, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

Assignees

@Pantani Pantani

Labels

ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pantani @julienrbrt