feat: add workflow to validade app registry files#196
Merged
Conversation
Pantani
changed the title
toschdev
reviewed
May 15, 2025
toschdev
reviewed
May 15, 2025
Contributor
|
Two minor things that might make sense:
|
julienrbrt
reviewed
May 17, 2025
julienrbrt
approved these changes
May 23, 2025
julienrbrt
approved these changes
May 23, 2025
Member
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
Non blocking questions. I guess well see after the merge lol
|
|
||
| - name: Fetch base branch | ||
| run: | | ||
| git fetch origin ${{ github.event.pull_request.base.ref }} |
Member
There was a problem hiding this comment.
Does it work on main? If it isn't a PR?
| GOTOOLCHAIN: local+path | ||
| GOSUMDB: off | ||
| run: go test -race -failfast -v -timeout 120m ./integration/... | ||
| run: go test -race -failfast -v -timeout 120m ./integration/... --branch ${{ github.event.pull_request.head.ref }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a workflow to validate new app registry files and changes to existing files.
Solution
Editing or creating a new file in the pull request will trigger the
validate-app-registry.ymlworkflow. Calling the newappregistrycommandignite appregistry validate <FILE_PATH>. This command validates the JSON file fields and URLs, and also checks if the Ignite version matches thego modversion from the app.This PR also creates a script to validate all app registry files: