Skip to content

Conversation

@ammar-elsabe
Copy link
Contributor

@ammar-elsabe ammar-elsabe commented Sep 17, 2025

This is the same issue as ignite/cli#4752 (by proxy from cosmossdk.io/[email protected]), fixed by upgrading to v1.6.1

command used:

$ fd go.mod | xargs rg -l 'cosmossdk.io/log' | xargs dirname | xargs -I{} bash -c 'echo "upgrading in {}" && cd {} && go get cosmossdk.io/[email protected] && go mod tidy && cd - > /dev/null' > upgrade-cosmossdk-log.log 2>&1

log: upgrade-cosmossdk-log.log

confirmation that it builds:

$ go version
go version go1.25.1 linux/amd64
$ fd go.mod | xargs rg -l 'cosmossdk.io/log' | xargs dirname | xargs -I{} bash -c 'echo "building in {}" && cd {} && go build -o {}-build && cd - > /dev/null'
building in fee-abstraction
building in appregistry
building in hermes
building in cca
building in connect
building in network
building in consumer
building in spaceship
building in examples/chain-info
building in evolve
building in examples/flags
building in examples/health-monitor
building in wasm
building in examples/hello-world
building in explorer

The same problem happened in CI which uses the latest go version when it tried to compile CLI at version v29.1.0, CLI patched this in v29.4.0 so its bumped as well

command:

$  fd go.mod | xargs rg -l 'github.com/ignite/cli/v29' | xargs dirname | xargs -I{} bash -c 'echo "upgrading in {}" && cd {} && go get github.com/ignite/cli/v29@latest && go mod tidy && cd - > /dev/null' > upgrade-ignite-cli.log 2>&1

log: upgrade-ignite-cli.log

@julienrbrt
Copy link
Member

Hi! Thanks for PR. Can you instead update cosmossdk.io/log to v1.6.1

@ammar-elsabe ammar-elsabe changed the title fix(deps): Support Go 1.25 by upgrading github.com/bytedance/sonic to v1.14.1 fix(deps): Support Go 1.25 by upgrading cosmossdk.io/log to v1.6.1 Sep 17, 2025
@ammar-elsabe
Copy link
Contributor Author

@julienrbrt updated PR

julienrbrt
julienrbrt previously approved these changes Sep 17, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@julienrbrt
Copy link
Member

can you check the failing tests?

@ammar-elsabe
Copy link
Contributor Author

@julienrbrt funny enough its due to the same reason. CLI fixed this in v29.4 but integration tests are using v29.3, ill give it the same treatment and update it everywhere in the repo

@julienrbrt
Copy link
Member

could you then bump CLI?

@ammar-elsabe ammar-elsabe changed the title fix(deps): Support Go 1.25 by upgrading cosmossdk.io/log to v1.6.1 fix(deps): Support Go 1.25 by upgrading cosmossdk.io/log to v1.6.1 and ignite/cli to v29.4.0 Sep 17, 2025
@ammar-elsabe
Copy link
Contributor Author

@julienrbrt done

@julienrbrt
Copy link
Member

can you unbump cli in the fee abstraction app https://github.com/ignite/apps/actions/runs/17798723794/job/50593911309?pr=226 😬

@ammar-elsabe
Copy link
Contributor Author

can you unbump cli in the fee abstraction app https://github.com/ignite/apps/actions/runs/17798723794/job/50593911309?pr=226 😬

@julienrbrt I could but this would fail for the same reason I bumped it no? go1.25 would not be able to compile cli <v25.4

i dont quite understand why its failing but would it be possible to fix fee abstraction to work with 29.4?

@julienrbrt
Copy link
Member

can you unbump cli in the fee abstraction app https://github.com/ignite/apps/actions/runs/17798723794/job/50593911309?pr=226 😬

@julienrbrt I could but this would fail for the same reason I bumped it no? go1.25 would not be able to compile cli <v25.4

i dont quite understand why its failing but would it be possible to fix fee abstraction to work with 29.4?

we should fix it yeah, but this can be done in a follow-up. Or we fix it first and merge main in this. Whatever you prefer.

@ammar-elsabe
Copy link
Contributor Author

can you unbump cli in the fee abstraction app https://github.com/ignite/apps/actions/runs/17798723794/job/50593911309?pr=226 😬

@julienrbrt I could but this would fail for the same reason I bumped it no? go1.25 would not be able to compile cli <v25.4

i dont quite understand why its failing but would it be possible to fix fee abstraction to work with 29.4?

we should fix it yeah, but this can be done in a follow-up. Or we fix it first and merge main in this. Whatever you prefer.

@julienrbrt its your repository so it's your choice lol, you could merge it now and ignore the CI failing (it would still fail if i unbumped it), or if you prefer not to do that I can revert the cli bump commit and you can merge it once you fix it and bump cli separately in main

@julienrbrt
Copy link
Member

yes, then please revert it but only for the fee abstraction app. we should still bump the other apps.

@ammar-elsabe
Copy link
Contributor Author

ammar-elsabe commented Sep 22, 2025

I was implying that the cli bump be done in another commit/PR with the fee abstraction fix, then we merge this on top of it, but it just occurred to me that even if you do that, that commit would have to be merged bypassing CI too, so idk, maybe i can change the target branch to one other than main and you take it from there? or if you insist ill unbump fee abstraction and you can follow up on fixing it once i reach home

@julienrbrt julienrbrt changed the title fix(deps): Support Go 1.25 by upgrading cosmossdk.io/log to v1.6.1 and ignite/cli to v29.4.0 build(deps): bump cosmossdk.io/log to v1.6.1 and ignite/cli to v29.4.0 Sep 22, 2025
@github-actions github-actions bot removed the app:wasm label Sep 22, 2025
@julienrbrt
Copy link
Member

tracked the rest here: #228. it will be done later.

@julienrbrt julienrbrt enabled auto-merge (squash) September 22, 2025 14:40
@julienrbrt julienrbrt merged commit dd1875e into ignite:main Sep 22, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants