Skip to content

docs: Update IBC tutorial #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
Jul 1, 2025
Merged

docs: Update IBC tutorial #4699

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3371f93
add transfertypes to ModuleCdc
toschdev May 22, 2025
b3d6f6d
Merge branch 'main' into ibc-tutorial
toschdev May 22, 2025
efa8c9d
Merge branch 'main' into ibc-tutorial
Pantani Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/docs/02-guide/04-ibc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ To identify the creator of the post in the receiving blockchain, add the
command because it would automatically become a parameter in the `SendIbcPost`
CLI command.

```protobuf title="proto/planet/blog/packet.proto"
```protobuf title="proto/planet/blog/v1/packet.proto"
message IbcPostPacketData {
string title = 1;
string content = 2;
Expand Down Expand Up @@ -338,6 +338,8 @@ from the packet.
```go title="x/blog/keeper/ibc_post.go"
package keeper

import transfertypes "github.com/cosmos/ibc-go/v10/modules/apps/transfer/types"

func (k Keeper) OnAcknowledgementIbcPostPacket(ctx sdk.Context, packet channeltypes.Packet, data types.IbcPostPacketData, ack channeltypes.Acknowledgement) error {
switch dispatchedAck := ack.Response.(type) {
case *channeltypes.Acknowledgement_Error:
Expand All @@ -346,7 +348,7 @@ func (k Keeper) OnAcknowledgementIbcPostPacket(ctx sdk.Context, packet channelty
case *channeltypes.Acknowledgement_Result:
// Decode the packet acknowledgment
var packetAck types.IbcPostPacketAck
if err := types.ModuleCdc.UnmarshalJSON(dispatchedAck.Result, &packetAck); err != nil {
if err := transfertypes.ModuleCdc.UnmarshalJSON(dispatchedAck.Result, &packetAck); err != nil {
// The counter-party module doesn't implement the correct acknowledgment format
return errors.New("cannot unmarshal acknowledgment")
}
Expand Down Expand Up @@ -410,6 +412,7 @@ The `earth.yml` and `mars.yml` files are required in the project directory:

```yaml title="earth.yml"
version: 1
validation: sovereign
build:
proto:
path: proto
Expand Down Expand Up @@ -438,6 +441,7 @@ validators:

```yaml title="mars.yml"
version: 1
validation: sovereign
build:
proto:
path: proto
Expand Down
Loading