Skip to content

refactor: replace Split in loops with more efficient SplitSeq #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 1 commit into from
Nov 19, 2025
Merged

refactor: replace Split in loops with more efficient SplitSeq #4839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ignite/services/chain/chain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,8 +587,8 @@ func (c *Chain) parseAddressPrefix() (string, error) {
}

// try to find the AccountAddressPrefix constant
lines := strings.Split(string(content), "\n")
for _, line := range lines {
lines := strings.SplitSeq(string(content), "\n")
for line := range lines {
// match both formats:
// AccountAddressPrefix = "cosmos"
// AccountAddressPrefix string = "cosmos"
Expand Down Expand Up @@ -631,8 +631,8 @@ func (c *Chain) parseCoinType() (uint32, error) {
}

// try to find the ChainCoinType constant
lines := strings.Split(string(content), "\n")
for _, line := range lines {
lines := strings.SplitSeq(string(content), "\n")
for line := range lines {
if strings.Contains(line, "ChainCoinType") && strings.Contains(line, "=") {
parts := strings.Split(line, "=")
if len(parts) < 2 {
Expand Down
Loading