Fix XEP-0124 BOSH compliance: overactivity exception, ack handling, sentElements cleanup

[Copilot]

Openfire's BOSH implementation had three spec deviations around overactivity enforcement, request acknowledgement parsing, and response ack redundancy.

Changes

OF-3219 — Overactivity allows pause/terminate (XEP-0124 §11)

XEP-0124 grants clients one extra simultaneous request when pausing or terminating. The check was unconditional, rejecting valid requests at the limit.

// Before
if (pendingConnections >= maxRequests) { overactivity = TOO_MANY_SIM_REQS; }

// After
final boolean isPauseOrTerminate = connection.isTerminate() || connection.getPause() != null;
final int maxSimultaneousRequests = isPauseOrTerminate ? maxRequests + 1 : maxRequests;
if (pendingConnections >= maxSimultaneousRequests) { overactivity = TOO_MANY_SIM_REQS; }

OF-3220 — Parse client ack attribute; prune sentElements (XEP-0124 §9.2)

Added HttpBindBody.getAck() to expose the client's acknowledged RID. When present, entries up to that RID are pruned from the sentElements retransmission buffer rather than relying solely on a maxRequests-sized cap. Unit tests added in HttpBindBodyTest.

OF-3221 — Suppress redundant ack in responses (XEP-0124 §9.1)

"the connection manager SHOULD NOT include an 'ack' attribute in any response if the value would be the 'rid' of the request being responded to"

asBodyText() and createEmptyBody() now accept the responding-to RID and omit ack when it would equal that RID — the common steady-state case. A deprecated no-arg overload of createEmptyBody(boolean) is retained for call sites without a request context.

---

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

[guusdk]

Copilot didn't exactly do what I wanted. I've manually created the desired PR in #3229 - that PR replaces this PR.