Skip to content

Group pop keys by continent#78

Open
likhitha-surapaneni wants to merge 2 commits intoigsr:masterfrom
likhitha-surapaneni:feature/map-key-color
Open

Group pop keys by continent#78
likhitha-surapaneni wants to merge 2 commits intoigsr:masterfrom
likhitha-surapaneni:feature/map-key-color

Conversation

@likhitha-surapaneni
Copy link
Contributor

@likhitha-surapaneni likhitha-surapaneni changed the title Grouped pop keys by continent Group pop keys by continent Mar 18, 2026
@ainefairbrother ainefairbrother self-requested a review March 20, 2026 13:28
@ainefairbrother ainefairbrother self-assigned this Mar 20, 2026
Copy link
Contributor

@ainefairbrother ainefairbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @likhitha-surapaneni, I think it looks really good and improves the map experience a lot. Only thing I think is that the "America" and "Asia" palettes look very similar and it's not easy to tell them apart when looking at the map as they're all pink-ish. One thing I could suggest is using grey for the "Middle East" superpopulation, as it's only got one population in it. This would free up the brown palette for "America", or else you could use 3 distinct grey shades for "America".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants