This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Conversation
koyashiro
reviewed
Mar 26, 2023
src/client.rs
Outdated
| } | ||
|
|
||
| impl Client { | ||
| pub fn new(id: u16, addr: String) -> Result<Self, anyhow::Error> { |
Member
There was a problem hiding this comment.
ここの addr の型 String じゃなくて UdpSocket::bind() の型に合わせたほうが良いかも
Suggested change
| pub fn new(id: u16, addr: String) -> Result<Self, anyhow::Error> { | |
| pub fn new(id: u16, addr: impl ToSocketAddrs) -> Result<Self, anyhow::Error> { |
koyashiro
reviewed
Mar 26, 2023
src/client.rs
Outdated
|
|
||
| pub trait ClientTrait { | ||
| fn get_id(&self) -> u16; | ||
| fn get_id_byte(&self) -> &[u8]; |
Member
There was a problem hiding this comment.
u16 から [u8; 2] への変換コストそんなに重くない気がするので、フィールドで保持せずメソッドで都度変換でも良いような
koyashiro
reviewed
Mar 26, 2023
src/client.rs
Outdated
| self.id | ||
| } | ||
|
|
||
| fn get_id_byte(&self) -> &[u8] { |
Member
There was a problem hiding this comment.
id が u16 なのは公開情報だから、ここは要素数を抽象化せず &[u8; 2] の方が良いかも
koyashiro
reviewed
Mar 26, 2023
Co-authored-by: koyashiro <6698252+koyashiro@users.noreply.github.com>
refactor: changed to move ownership instead of borrowing reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.