refactor(instant): Make instant an optional dependency#70
Open
amnn wants to merge 1 commit intoihrwein:masterfrom
Open
refactor(instant): Make instant an optional dependency#70amnn wants to merge 1 commit intoihrwein:masterfrom
amnn wants to merge 1 commit intoihrwein:masterfrom
Conversation
The `instant` crate is used by `backoff` to support the `Instant` type when compiling to WASM, but it is currently unmaintained. This PR makes the dependency optional, so that clients that do not need this feature can avoid taking the dependency. The feature is enabled by default so this change should not be breaking, but it allows downstream packages to disable default features if they don't need to take the dependency. A separate PR is required to change the dependency to something like `web-time` that is currently maintained. ## Test plan Ran tests with and without the feature enabled: ``` cargo nextest run cargo nextest run --no-default-features cargo nextest run --no-default-features --features wasm-bindgen cargo nextest run --features wasm-bindgen ```
8 tasks
|
I was just starting to work on a change to also remove instant due to it no longer being maintained. Please consider merging this PR so we can remove the instant dependency. Alternatively if you would prefer a migration to web-time instead I would be happy to send a PR that does that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
instantcrate is used bybackoffto support theInstanttype when compiling to WASM, but it is currently unmaintained. This PR makes the dependency optional, so that clients that do not need this feature can avoid taking the dependency.The feature is enabled by default so this change should not be breaking, but it allows downstream packages to disable default features if they don't need to take the dependency.
A separate PR is required to change the dependency to something like
web-timethat is currently maintained.Test plan
Ran tests with and without the feature enabled: