Skip to content

Fix various issues#74

Merged
phackstock merged 31 commits intomainfrom
feature/fix-publishing
Jul 25, 2025
Merged

Fix various issues#74
phackstock merged 31 commits intomainfrom
feature/fix-publishing

Conversation

@phackstock
Copy link
Contributor

@phackstock phackstock commented Jul 24, 2025

Closes #69, closes #72, closes #73, closes #75, closes #77, closes #78, closes #51.

  • Tests added
  • Documentation added
  • Example added (in the documentation, to an existing notebook, or in a new notebook)
  • Description in CHANGELOG.rst added (single line such as: (`#XX <https://github.com/iiasa/climate-assessment/pull/XX>`_) Added feature which does something)

@phackstock phackstock changed the title Feature/fix publishing Fix various issues Jul 24, 2025
@phackstock phackstock requested review from jkikstra and znicholls July 25, 2025 07:43
@phackstock phackstock self-assigned this Jul 25, 2025
@phackstock phackstock added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jul 25, 2025
@phackstock phackstock added this to the v0.1.5 milestone Jul 25, 2025
Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes, but all look like it is package management and updating test syntax.
As long as it works, I don't have objections.

However, it looks like installation docs now should be updated?
https://github.com/iiasa/climate-assessment/blob/main/doc/install.rst

@phackstock
Copy link
Contributor Author

Many changes, but all look like it is package management and updating test syntax.
As long as it works, I don't have objections.

Exactly, the bigger changes were in #68. This PR is more of a cleanup and update of the small little issues that were only found when trying to publish.

The installation docs are mostly still correct, the only part that needs updating is for the developing the software. I can update that too.

@phackstock phackstock requested a review from jkikstra July 25, 2025 08:58
jkikstra
jkikstra previously approved these changes Jul 25, 2025
Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, installation docs now clear also to me :).

Tests running fine locally too.

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phackstock, the repo needs a lot of love and now it's got some (all?) of it

@phackstock
Copy link
Contributor Author

@znicholls, some tlc was needed for sure 😄, now it should be hopefully good for the foreseeable future. With the nightly builds now back in place, we should also be notified once things start to break again. Which hopefully won't be for a while 🤞.

@phackstock phackstock merged commit 6e1be09 into main Jul 25, 2025
11 checks passed
@phackstock phackstock deleted the feature/fix-publishing branch July 25, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

3 participants