Skip to content

Feat: send pid for the engine#40

Closed
guibeira wants to merge 1 commit intomainfrom
feat/send-pid-for-the-engine
Closed

Feat: send pid for the engine#40
guibeira wants to merge 1 commit intomainfrom
feat/send-pid-for-the-engine

Conversation

@guibeira
Copy link
Contributor

@guibeira guibeira commented Mar 2, 2026

Summary by CodeRabbit

  • Chores
    • Extended worker metadata collection to include process identifier across Node.js, Python, and Rust implementations.

@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05fbdfc and e117934.

⛔ Files ignored due to path filters (1)
  • packages/python/iii-example/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • packages/node/iii/src/iii.ts
  • packages/python/iii/src/iii/iii.py
  • packages/rust/iii/src/iii.rs

📝 Walkthrough

Walkthrough

Process ID tracking is added to worker metadata telemetry across Node.js, Python, and Rust SDK implementations. Each package extends its worker metadata payload to include the current process ID without altering existing functionality.

Changes

Cohort / File(s) Summary
Node.js Worker Metadata
packages/node/iii/src/iii.ts
Added pid: process.pid to the worker metadata payload in registerWorkerMetadata.
Python Worker Metadata
packages/python/iii/src/iii/iii.py
Added pid field with os.getpid() to the dict returned by _get_worker_metadata().
Rust Worker Metadata
packages/rust/iii/src/iii.rs
Added pub pid: Option<u32> field to WorkerMetadata struct with serde skip_serializing_if = "Option::is_none" annotation and updated Default implementation to set pid: Some(pid).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Our workers now wear badges bright,
With PIDs shining in the light,
Three tongues speak one harmonious tune,
Telemetry blooms like spring in June! 🌱

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Feat: send pid for the engine' clearly and directly summarizes the main change across all modified files—adding process ID information to worker metadata payloads.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/send-pid-for-the-engine

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@guibeira
Copy link
Contributor Author

guibeira commented Mar 4, 2026

moved to mono repo:
iii-hq/iii#1229

@guibeira guibeira closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant