-
Notifications
You must be signed in to change notification settings - Fork 13
Remove rollup-plugin-ts #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f070fa0
chore: Temporarily committed dist
ijlee2 f97ce34
chore: Removed rollup-plugin-ts
ijlee2 01c9c64
chore: Temporarily committed declarations and dist
ijlee2 72edb9b
bugfix: Removed .hbs from extensions
ijlee2 accf460
chore: Committed dist
ijlee2 9a1d914
chore: Reverted committing declarations and dist
ijlee2 ccc9fe0
bug: Use glint -d
ijlee2 0ad7200
Revert "bug: Use glint -d"
ijlee2 ae9e11e
bugfix: Generalized scripts and TS configurations (works for both tsc…
ijlee2 7c40eba
Revert "bugfix: Generalized scripts and TS configurations (works for …
ijlee2 ce05d01
Revert "Revert "bug: Use glint -d""
ijlee2 760c564
bugfix: Removed @glint-ignore comment, which had caused TypeScript to…
ijlee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ | |
| /blueprints/*/files/ | ||
|
|
||
| # compiled output | ||
| /declarations/ | ||
| /dist/ | ||
|
|
||
| # misc | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| # compiled output | ||
| /declarations/ | ||
| /dist/ | ||
|
|
||
| # dependencies | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,11 +3,26 @@ | |
|
|
||
| import '@glint/environment-ember-loose'; | ||
|
|
||
| import { ComponentLike, HelperLike } from '@glint/template'; | ||
|
|
||
| import EmberContainerQueryRegistry from '../src/template-registry'; | ||
|
|
||
| interface ElementHelperSignature<T extends string> { | ||
| Args: { | ||
| Positional: [name: T]; | ||
| }; | ||
| Return: ComponentLike<{ | ||
| Blocks: { default: [] }; | ||
| Element: T extends keyof HTMLElementTagNameMap | ||
| ? HTMLElementTagNameMap[T] | ||
| : Element; | ||
| }>; | ||
| } | ||
|
Comment on lines
+10
to
+20
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| declare module '@glint/environment-ember-loose/registry' { | ||
| export default interface Registry extends EmberContainerQueryRegistry { | ||
| // Add any registry entries from other addons here that your addon itself uses (in non-strict mode templates) | ||
| // See https://typed-ember.gitbook.io/glint/using-glint/ember/using-addons | ||
| element: HelperLike<ElementHelperSignature>; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,10 +39,5 @@ | |
| "enhance: documentation": "Documentation", | ||
| "user feedback": "User Feedback" | ||
| } | ||
| }, | ||
| "pnpm": { | ||
| "patchedDependencies": { | ||
| "[email protected]": "patches/[email protected]" | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dan on Discord: