Add Parameter to Disable Verification of Server Certificate #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new ROS parameter to optionally disable server certificate verification for MQTT connections with self-signed certificates. The change allows users to bypass SSL certificate validation when connecting to MQTT brokers that use self-signed certificates.
- Introduces
client.tls.server_cert_authparameter (defaults totrue) to control server certificate verification - Updates configuration structure and client setup to use the new parameter
- Documents the new parameter in README with default value
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mqtt_client/src/MqttClient.cpp | Adds parameter declaration, loading logic, and SSL configuration setup |
| mqtt_client/include/mqtt_client/MqttClient.hpp | Extends TLS configuration structure with server_cert_auth field |
| README.md | Documents the new server_cert_auth parameter with default value |
lreiher
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new boolean
client.tls.server_cert_authROS parameter (trueby default) to optionally disable verification of the server certificate. This is helpful in case the MQTT broker uses a self-signed certificate, which cannot be verified at the client side. The implementation uses the set_enable_server_cert_auth method of the Eclipse Paho MQTT C++ Client Library (see also code on GitHub). Closes #86.