Added fisheye camera (equidistant model) support and fixed some minor errors#13
Open
mgrova wants to merge 8 commits intoika-rwth-aachen:mainfrom
Open
Added fisheye camera (equidistant model) support and fixed some minor errors#13mgrova wants to merge 8 commits intoika-rwth-aachen:mainfrom
mgrova wants to merge 8 commits intoika-rwth-aachen:mainfrom
Conversation
…ge_cloud' to ensure equisitant samples
Member
|
Can you please add a screenshot of you Fish-Eye Camera Calibration ? So that I can see that it works ? Or provide me a rosbag so that I can test your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for cameras with equidistant or fisheye distortion models. To do this, a method has been created that allows the camera model used to be identified and, with this information, a method for projecting the points or another method to be used.
In addition, the following have been fixed/modified:
To fix this, this snippet has been added.
I would be delighted to receive any comments or modifications you may have :)
Bests,
Marco.