Skip to content

Conversation

EmreK03
Copy link
Collaborator

@EmreK03 EmreK03 commented Sep 16, 2025

This MR updates the behavior of the Image and PointCloud2 display dropdown in RViz2. Previously, the dropdown only listed topics of type sensor_msgs/msg/Image, so CompressedImage topics (e.g., /camera/image/compressed) were not visible, even though RViz2 could already visualize them. Same for sensor_msgs/msg/PointCloud2 and point_cloud_interfaces/msg/CompressedPointCloud2.

With this change, Compressed image and pointcloud2 topics are now included in the dropdown menu, making it easier for users to select these topics without manually typing the topic name.

Additionally, Compressed image and pointcloud2 topics are also shown in the By topic section thanks to the change in plugins_description.xml.

Image Display added by display type:
image

Image Display added by topic (same results):
image

PointCloud2 Display added by display type:
image

PointCloud2 Display added by topic (same results):
image

@EmreK03 EmreK03 requested a review from jpbusch September 16, 2025 10:57
@EmreK03 EmreK03 self-assigned this Sep 16, 2025
@EmreK03 EmreK03 added the enhancement New feature or request label Sep 16, 2025
@EmreK03 EmreK03 requested review from lreiher and Copilot and removed request for jpbusch September 16, 2025 11:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends RViz2's Image display plugin to support CompressedImage topics by making them visible in dropdown menus and topic lists. Previously, only standard Image topics appeared in the dropdown, requiring users to manually type CompressedImage topic names.

Key changes:

  • Added CompressedImage message type to the Image display plugin description
  • Modified topic filtering logic to include CompressedImage topics when Image topics are expected

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
rviz_default_plugins/plugins_description.xml Added CompressedImage message type to Image display plugin configuration
rviz_common/src/rviz_common/properties/ros_topic_property.cpp Updated topic filtering to show CompressedImage topics in Image display dropdown

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@lreiher lreiher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after these minor suggestions are incorporated. Will then need to rebase these commits on the upstream rolling branch and post a PR against the upstream repository.

If you like, you may do this yourself. @jpbusch can show you how and quickly discuss this with you.

@jpbusch jpbusch force-pushed the jazzy-dropdown-menu-compressed-option branch from 8505f81 to 1d89797 Compare October 6, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants