-
Notifications
You must be signed in to change notification settings - Fork 1
Jazzy dropdown menu compressed option #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jazzy
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR extends RViz2's Image display plugin to support CompressedImage topics by making them visible in dropdown menus and topic lists. Previously, only standard Image topics appeared in the dropdown, requiring users to manually type CompressedImage topic names.
Key changes:
- Added CompressedImage message type to the Image display plugin description
- Modified topic filtering logic to include CompressedImage topics when Image topics are expected
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
rviz_default_plugins/plugins_description.xml | Added CompressedImage message type to Image display plugin configuration |
rviz_common/src/rviz_common/properties/ros_topic_property.cpp | Updated topic filtering to show CompressedImage topics in Image display dropdown |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved after these minor suggestions are incorporated. Will then need to rebase these commits on the upstream rolling branch and post a PR against the upstream repository.
If you like, you may do this yourself. @jpbusch can show you how and quickly discuss this with you.
rviz_common/include/rviz_common/properties/ros_topic_property.hpp
Outdated
Show resolved
Hide resolved
rviz_default_plugins/include/rviz_default_plugins/displays/image/image_transport_display.hpp
Outdated
Show resolved
Hide resolved
...t_plugins/include/rviz_default_plugins/displays/pointcloud/point_cloud_transport_display.hpp
Outdated
Show resolved
Hide resolved
…play dropdown menu
Co-authored-by: Lennart Reiher <[email protected]> Signed-off-by: Emre <[email protected]>
Co-authored-by: Lennart Reiher <[email protected]> Signed-off-by: Emre <[email protected]>
Co-authored-by: Lennart Reiher <[email protected]> Signed-off-by: Emre <[email protected]>
Signed-off-by: Emre <[email protected]>
8505f81
to
1d89797
Compare
This MR updates the behavior of the Image and PointCloud2 display dropdown in RViz2. Previously, the dropdown only listed topics of type
sensor_msgs/msg/Image
, soCompressedImage
topics (e.g.,/camera/image/compressed
) were not visible, even though RViz2 could already visualize them. Same forsensor_msgs/msg/PointCloud2
andpoint_cloud_interfaces/msg/CompressedPointCloud2
.With this change, Compressed image and pointcloud2 topics are now included in the dropdown menu, making it easier for users to select these topics without manually typing the topic name.
Additionally, Compressed image and pointcloud2 topics are also shown in the By topic section thanks to the change in
plugins_description.xml
.Image Display added by display type:

Image Display added by topic (same results):

PointCloud2 Display added by display type:

PointCloud2 Display added by topic (same results):
