Skip to content

Port of Qwen3-VL support from mainline #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Port of Qwen3-VL support from mainline #883

wants to merge 7 commits into from

Conversation

@Thireus
Copy link
Contributor

@Thireus Thireus commented Oct 30, 2025

  • convert_hf_to_gguf.py - Not touched, use llama.cpp to convert model instead
  • sycl and metal support for imrope not added - See ggml-metal and ggml-sycl folders of https://github.com/ggml-org/llama.cpp/pull/16780/files
  • Vulkan support for imrope not tested
  • Code not tested against any GGUF (looking for testers...)

Source: ggml-org/llama.cpp#16780

@Thireus
Port of Qwen3-VL for latest ik_llama.cpp
0e6f8b2 
- convert_hf_to_gguf.py - Not touched, use llama.cpp to convert model instead
- sysl and metal support for imrope not added
- Vulkan support for imrope not tested
- Code not tested
@ranilongxi
Copy link

I tried to build this branch with cpu-only and CUDA but it kept failing:

CUDA
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DGGML_LTO=ON -DGGML_NATIVE=ON -DGGML_CUDA=ON -DGGML_CUDA_F16=ON -DGGML_CUDA_FA_ALL_QUANTS=ON -DGGML_CUDA_DMMV_F16=ON -DGGML_CUDA_FORCE_MMQ=ON -DCMAKE_CUDA_ARCHITECTURES=89 -DLLAMA_CURL=ON -DGGML_BLAS=OFF -DGGML_SCHED_MAX_COPIES=1

FAILED: src/CMakeFiles/llama.dir/llama-load-tensors.cpp.o .../llama-load-tensors.cpp:1006:13: error: conflicting declaration 'int64_t n_embd' int64_t n_embd = hparams.n_embd / (hparams.n_deepstack_layers + 1); ^~~~~~ .../llama-load-tensors.cpp:227:40: note: previous declaration as 'const int64_t n_embd' [[maybe_unused]] const int64_t n_embd = hparams.n_embd; \ ... in expansion of macro 'LOADING_PRELUDE' .../llama-load-tensors.cpp:1045:13: error: conflicting declaration 'int64_t n_embd'
CPU only
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release ninja -C build -j22

FAILED: src/CMakeFiles/llama.dir/llama-load-tensors.cpp.o .../llama-load-tensors.cpp:1006:13: error: conflicting declaration 'int64_t n_embd' .../llama-load-tensors.cpp:227:40: note: previous declaration as 'const int64_t n_embd' ... in expansion of macro 'LOADING_PRELUDE'

@Thireus
Copy link
Contributor Author

Thireus commented Oct 31, 2025

@ranilongxi, thank you; should be fixed now.

@Thireus Thireus mentioned this pull request Oct 31, 2025
Merged
4 tasks
ikawrakow
ikawrakow reviewed Oct 31, 2025
View reviewed changes
Copy link
Owner

@ikawrakow ikawrakow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, LGTM.

But we need to get this tested by someone before merging.

@Thireus
Copy link
Contributor Author

Thireus commented Oct 31, 2025

Thank you @ikawrakow, I'll do my best to resolve your comments. There are still some compilation issues which I'll resolve as well.

@Thireus
Copy link
Contributor Author

Thireus commented Oct 31, 2025 •
edited
Loading

@ikawrakow please let me know if you are happy with how I've addressed your comments:
e552942
and
6a24dec

ikawrakow
ikawrakow reviewed Oct 31, 2025
View reviewed changes
@Thireus Thireus mentioned this pull request Oct 31, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikawrakow ikawrakow ikawrakow left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thireus @ranilongxi @ikawrakow