Added a test for the control+left and control+right keyboard shortcuts#503
Added a test for the control+left and control+right keyboard shortcuts#503cosmincalinov wants to merge 2 commits intoilai-deutel:masterfrom
Conversation
ilai-deutel
left a comment
There was a problem hiding this comment.
Thanks a lot for adding tests, increasing coverage is always great!
There are actually already tests for previous/next word shortcuts, see editor_move_cursor_left and editor_move_cursor_right. However I like that your PR tests using editor.process_keypress(...), which is a higher-level function, so it's closer to the "public" interface, and more useful to test.
Instead of creating a new test, I think it could make sense to update the existing ones to use editor.process_keypress(...) instead of editor.move_cursor(...), what do you think?
|
@all-contributors Please add @cosmincalinov for test. |
|
I've put up a pull request to add @cosmincalinov! 🎉 |
Agreed, it would be way easier to read and more intuitive i think. |
Checked if the Ctrl + ← and Ctrl + → keyboard shortcuts behaved correctly in the editor.