add export source option to object classification#139
add export source option to object classification#139k-dominik merged 3 commits intoilastik:mainfrom
Conversation
k-dominik
left a comment
k-dominik
left a comment
There was a problem hiding this comment.
Hello @biovoxxel,
thank you so much for your contribution! I think it's super useful to be able to export the object identities from ilastik. Dream would be to also handle the table some day (#84)...
I left some suggestions, but my java is rusty to say the least ;)
src/main/java/org/ilastik/ilastik4ij/workflow/ObjectClassificationCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ilastik/ilastik4ij/workflow/ObjectClassificationCommand.java
Outdated
Show resolved
Hide resolved
- absolute Strings exchanged for constants - collapse return of Collection.singletonList into single String.format line
|
Hi @k-dominik, I added the changes you requested and tested the code in Fiji. It should be ready for release. |
k-dominik
left a comment
k-dominik
left a comment
There was a problem hiding this comment.
Hey @biovoxxel,
thank you so much for your contribution @biovoxxel, there are some small issues remaining with macro backwards compatibility, but I can fix those if you don't necessarily want to do it at this time!
|
Okay I guess I forgot about scijava/scijava-common#317 ... Plugin will not be backwards compatible for macro usage in object classification, but I guess that's a limitation we're going to have to live with. Probably a good idea to bump the minor version at least. |
and use string constant rather than another occurrence of the string for objectExportSource.
|
Thank you very much @biovoxxel, we'll do a release soon! |
2 participants
I added an additional dialog to the object classification wrapper that allows to choose if object predictions, probabilities, or identities are exported.
Especially the identities are super helpful in Fiji to analyze the predictions per object instance.