This repository was archived by the owner on Dec 29, 2025. It is now read-only.
Fix compile error on macOS #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting this error on macOS: ``` ld: library 'c++' not found clang++: error: linker command failed with exit code 1 (use -v to see invocation) ``` Took a while to track down the issue, but it turned out this warning at the end of `cmake` was key: ``` CMake Warning at src/CMakeLists.txt:40 (target_link_libraries): Target "clickhouse_fdw" requests linking to directory "/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk". Targets may link only to libraries. CMake is dropping the item. ``` This is fine, except that that CMake doesn't remove the option this directory points to. The option is stored by `pg_config`; you can see it here: ``` console pg_config --ldflags -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX15.5.sdk -L/opt/homebrew/opt/readline/lib -Wl,-dead_strip_dylibs ``` What we need to do is remove both the macOS SDK and `-isysroot`. So add a section to `CMakeLists.txt` that uses `REGEX REPLACE` to remove the complete option from the output of `pg_config` on macOS.
Contributor
Author
|
Oddly it named the resulting file |
Owner
|
Thanks! |
Contributor
Author
|
Thanks. Any thoughts on how to fix the incorrect file name? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error on macOS
I was getting this error on macOS:
Took a while to track down the issue, but it turned out this warning at the end of
cmakewas key:This is fine, except that that CMake doesn't remove the option this directory points to. The option is stored by
pg_config; you can see it here:What we need to do is remove both the macOS SDK and
-isysroot. So add a section toCMakeLists.txtthat usesREGEX REPLACEto remove the complete option from the output ofpg_configon macOS.