Skip to content

Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ilesinge wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Draft

Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions shabda/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@
def save(key, value, ttl=60 * 60 * 24):
"""Write a key:value pair to cache."""
# ttl is "time to live" of the item in seconds
filepath = CACHE_PATH + key
filepath = os.path.normpath(os.path.join(CACHE_PATH, key))
# Ensure the normalized filepath is within CACHE_PATH
if not filepath.startswith(os.path.normpath(CACHE_PATH)):
raise Exception("Invalid cache key: path traversal detected")
expiry = int(time.time() + ttl)
cache = (expiry, value)
with open(filepath, "w+b") as file:
Expand All @@ -23,7 +26,10 @@ def save(key, value, ttl=60 * 60 * 24):

def load(key):
"""Read the value for given key from cache."""
filepath = CACHE_PATH + key
filepath = os.path.normpath(os.path.join(CACHE_PATH, key))
# Ensure the normalized filepath is within CACHE_PATH
if not filepath.startswith(os.path.normpath(CACHE_PATH)):
raise Exception("Invalid cache key: path traversal detected")
try:
with open(filepath, "r+b") as file:
expiry, value = pickle.load(file)
Expand Down