Sonarcloud vernability fix issue #2865 #3058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluwatar
requested changes
Nov 3, 2024
Owner
iluwatar
left a comment
iluwatar
left a comment
There was a problem hiding this comment.
The build is failing due to checkstyle errors
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
bot
added
the
status: stale
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
solves some of the vernability fix from issue #2865
Use already-defined constant 'BINARY_DATA' instead of duplicating its value here.
Define a constant instead of duplicating this literal " -------------------------- " 4 times.
Fix this access on a collection that may trigger an 'ArrayIndexOutOfBoundsException'.