Skip to content

docs: Improve Anti-Corruption-Layer README(#3200) #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

docs: Improve Anti-Corruption-Layer README(#3200) #3206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion anti-corruption-layer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public class LegacyShop {

String id = legacyOrder.getId();

Optional<LegacyOrder> orderInModernSystem = acl.findOrderInModernSystem(id);
Optional<ModernOrder> orderInModernSystem = acl.findOrderInModernSystem(id);
Copy link

@github-actions github-actions bot Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of orderInModernSystem has changed from Optional<LegacyOrder> to Optional<ModernOrder>. Ensure this change is consistent with the overall design and doesn't introduce unexpected behavior or break existing functionality.


if (orderInModernSystem.isPresent()) {
// order is already in the modern system
Expand Down
Loading