Skip to content

Conversation

@e5LA
Copy link
Contributor

@e5LA e5LA commented Apr 30, 2025

Pull Request Template

What does this PR do?

  1. Upgrading JUnit to version 5.12.2.
  2. Replacing individual dependencies (junit-jupiter-engine and junit-jupiter-params) with the junit-jupiter aggregator package https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter
  3. Moving mockito-junit-jupiter dependency to the parent pom.xml as it was previously declared with explicit versions in some modules. Also, excluding junit-jupiter-api from this dependency since the latest mockito-junit-jupiter version includes older version of junit-jupiter-api, which was causing test failures.
  4. Refactoring SimpleFileWriterTest to be compatible with JUnit 5.

Fixes #3259

@github-actions
Copy link

Analyzing changes in this PR...

This might take a few minutes, please wait

📥 Commits

Analyzing changes from base (8a64f4c) to latest commit (afe3910):

  • afe3910: refactor: using junit 5 in the test
  • eb70db2: build: moving mockito-junit-jupiter to dependencyManagement
  • b684cc7: build: adding junit dependency to the module
  • 445b395: build: using junit aggregator
  • 04a66d9: build: bump junit.version from 5.11.4 to 5.12.2 + using junit aggregator
📁 Files being considered (30)

🔄 abstract-document/pom.xml (1 hunk)
🔄 abstract-factory/pom.xml (1 hunk)
🔄 active-object/pom.xml (1 hunk)
🔄 actor-model/pom.xml (1 hunk)
🔄 acyclic-visitor/pom.xml (1 hunk)
🔄 adapter/pom.xml (1 hunk)
🔄 ambassador/pom.xml (1 hunk)
🔄 anti-corruption-layer/pom.xml (1 hunk)
🔄 arrange-act-assert/pom.xml (1 hunk)
🔄 async-method-invocation/pom.xml (1 hunk)
🔄 backpressure/pom.xml (1 hunk)
🔄 balking/pom.xml (1 hunk)
🔄 bloc/pom.xml (1 hunk)
🔄 bridge/pom.xml (1 hunk)
🔄 builder/pom.xml (1 hunk)
🔄 business-delegate/pom.xml (1 hunk)
🔄 bytecode/pom.xml (1 hunk)
🔄 caching/pom.xml (1 hunk)
🔄 callback/pom.xml (1 hunk)
🔄 chain-of-responsibility/pom.xml (1 hunk)
🔄 circuit-breaker/pom.xml (1 hunk)
🔄 clean-architecture/pom.xml (1 hunk)
🔄 client-session/pom.xml (1 hunk)
🔄 collecting-parameter/pom.xml (1 hunk)
🔄 collection-pipeline/pom.xml (1 hunk)
🔄 combinator/pom.xml (1 hunk)
🔄 command-query-responsibility-segregation/pom.xml (1 hunk)
🔄 command/pom.xml (1 hunk)
🔄 commander/pom.xml (1 hunk)
🔄 component/pom.xml (1 hunk)


autogenerated by presubmit.ai

@e5LA e5LA changed the title build: bump junit.version from 5.11.4 to 5.12.2 + clean up bump junit.version from 5.11.4 to 5.12.2 + clean up Apr 30, 2025
@e5LA e5LA changed the title bump junit.version from 5.11.4 to 5.12.2 + clean up ENHANCEMENT: bump junit.version from 5.11.4 to 5.12.2 + clean up Apr 30, 2025
@sonarqubecloud
Copy link

@e5LA
Copy link
Contributor Author

e5LA commented May 1, 2025

hi @iluwatar,
I'm not sure how Presubmit.ai determines the PR type. I've updated the PR title - would re-triggering the job resolve the issue, or should I update the commit messages instead?

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Jul 1, 2025
@e5LA
Copy link
Contributor Author

e5LA commented Jul 1, 2025

Its pending review

@github-actions github-actions bot removed the Stale label Jul 3, 2025
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant