Skip to content

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Aug 29, 2025 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Aug 29, 2025

Deploying image-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e7f607f
Status: ✅  Deploy successful!
Preview URL: https://0b71e220.image-js-docs.pages.dev
Branch Preview URL: https://143-review-documentation-slu.image-js-docs.pages.dev

View logs

@EscapedGibbon
Copy link
Contributor Author

@targos that might be an overkill, but I think it's better to make files kebab-case so that it will be a default way of naming ".md" files instead of writing slugs for each file separately. Maybe also add a check for filenames so that they are all kebab-case?

@EscapedGibbon EscapedGibbon marked this pull request as ready for review August 29, 2025 13:25
@EscapedGibbon EscapedGibbon requested a review from targos August 29, 2025 13:27
@targos
Copy link
Member

targos commented Aug 29, 2025

Yes of course, it didn't even cross my mind to specify the slug separately from the file name.

@targos
Copy link
Member

targos commented Aug 29, 2025

Maybe also add a check for filenames so that they are all kebab-case?

Yes, good idea.

@EscapedGibbon EscapedGibbon force-pushed the 143-review-documentation-slugs branch from a537267 to 1f8fd65 Compare August 30, 2025 15:09
@EscapedGibbon EscapedGibbon force-pushed the 143-review-documentation-slugs branch from 1f8fd65 to 52efb48 Compare August 30, 2025 15:13
@EscapedGibbon EscapedGibbon requested a review from targos September 2, 2025 13:38
@targos targos merged commit 79d7e72 into main Sep 3, 2025
9 checks passed
@targos targos deleted the 143-review-documentation-slugs branch September 3, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review documentation slugs
2 participants