Stop doing color conversion when decoding JPEG compressed images#274
Merged
fintelia merged 1 commit intoimage-rs:mainfrom Jun 22, 2025
Merged
Stop doing color conversion when decoding JPEG compressed images#274fintelia merged 1 commit intoimage-rs:mainfrom
fintelia merged 1 commit intoimage-rs:mainfrom
Conversation
fintelia
force-pushed
the
jpeg-no-color-conversion
branch
from
64928fc to
6d30abb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my read of TIFF Technical Note #2, we shouldn't be doing color conversion at all.
One weird consequence of this is that if the JPEG data is CMYK but the TIFF header specifies the data is 4 samples per pixel with with a photometric interpretation RGB, then the four channels of JPEG data will be treated as RGBA.
Fixes #260