Conversation
The key motivation here is the ability to represent the tags within a directory separate from a file. This allows us to represent directories that are not image directories, i.e. the EXIF directory, the related GPS directory, and other sub directories. These are defined by a 'pointer' value in another tag, an offset into the file. They can then be read from that immediate location.
Member
Author
|
Is this repository intentionally setup to use squash merges? That would be different from all the rest of the |
Contributor
|
I probably switched it the last time I made changes to this repository's settings. If you'd rather other merge types (or even just want to use them occasionally) feel free to re-enable them in the settings. I have a slight preference for squash merges since PRs frequently have a lot of pointless "fix typo" style commits (mine certainly do!) and GitHub's commit history page doesn't let you filter to only merges. By contrast, if you do want to see the individual commits for a merged PR, GitHub saves them even for deleted branches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key motivation here is the ability to represent the tags within a
directory separate from a file. This allows us to represent directories
that are not image directories, i.e. the EXIF directory, the related GPS
directory, and other sub directories. These are defined by a 'pointer'
value in another tag, an offset into the file. They can then be read
from that immediate location.
Another PR will add methods to turn the entries of a
Directoryintoifd::Valuesby using the reader / bigtiff / byte order / limits configuration from a value, which would then be enough to make Exif and GPS directories useful.