Conversation
197g
commented
Jul 8, 2025
This allows us to recombine the reader and other file data in a Decoder with any IFD, whether that of an image or an extension IFD as indicated by an IFD pointer such as Exif and GPS.
Having the value reader itself take care of the bigtiff and limit semantics is a little cleaner, with the TagReader being responsible for the interface of grabbing specific types of IFD values.
Merged
fintelia
approved these changes
Jul 12, 2025
Member
|
I would appreciate an addition to the docs on |
Member
Author
|
@Shnatsel PTAL at the added documentation? |
Member
|
Looks good to me, thank you! |
Member
Author
|
I'm going to do a pass over the Decoder interface so that it works with the |
This was referenced Jul 19, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the internals of
Decoderas a side effect, in particular groups all attributes needed to correctly interpretEntryas anifd::Value. The main reason is that it simplifies borrow-checking however it also simplifies some interfaces where we previously passed those values as separate arguments despite needing them together.Newly public interfaces are:
ifd::Value::into_ifd_pointer,ifd::Value::into_ifd_vecdecoder::Decoder::read_directorydecoder::Decoder::read_directory_tagsdecoder::IfdDecoder