Conversation
Fax was commonly requested, so let's make it Just Work when tiff crate is used through `image` where it's difficult to fiddle with tiff crate features.
197g
reviewed
Aug 31, 2025
Member
197g
left a comment
There was a problem hiding this comment.
I'm not sure if it is ready as such, yet. I'm glad for using fax and it certainly does something non-trivial with a decent implementation; but it also uses a build-time syn=1 dependency for an internal derive feature. Before having it on as a default feature I'd like to ensure we're on a cleaner dependency tree—it's harder to turn off than on and in image we don't use an explicit feature list.
Member
Author
|
All right. I've opened an issue upstream to upgrade to syn 2.x, Never mind, we're still not handling photometric interpretation correctly: #229 (comment) |
Member
Author
|
|
197g
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fax was commonly requested, so let's make it Just Work when tiff crate is used through
imagewhere it's difficult to fiddle with tiff crate features.