Skip to content

Make fax a default feature#294

Merged
197g merged 1 commit intomainfrom
fax-default-feature
Sep 1, 2025
Merged

Make fax a default feature#294
197g merged 1 commit intomainfrom
fax-default-feature

Conversation

@Shnatsel
Copy link
Member

Fax was commonly requested, so let's make it Just Work when tiff crate is used through image where it's difficult to fiddle with tiff crate features.

Fax was commonly requested, so let's make it Just Work when tiff crate is used through `image` where it's difficult to fiddle with tiff crate features.
@Shnatsel Shnatsel requested a review from 197g August 31, 2025 14:28
Copy link
Member

@197g 197g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is ready as such, yet. I'm glad for using fax and it certainly does something non-trivial with a decent implementation; but it also uses a build-time syn=1 dependency for an internal derive feature. Before having it on as a default feature I'd like to ensure we're on a cleaner dependency tree—it's harder to turn off than on and in image we don't use an explicit feature list.

@Shnatsel
Copy link
Member Author

Shnatsel commented Aug 31, 2025

All right. I've opened an issue upstream to upgrade to syn 2.x, but for now let's just go ahead and cut a release with fax support present but not enabled by default.

Never mind, we're still not handling photometric interpretation correctly: #229 (comment)

@Shnatsel
Copy link
Member Author

fax v0.2.6 is now up with an upgrade to syn 2.x

@197g 197g merged commit 64286c2 into main Sep 1, 2025
15 checks passed
@197g 197g deleted the fax-default-feature branch September 1, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants