Conversation
197g
force-pushed
the
public-byte-order
branch
from
612eed0 to
d294de4
Compare
197g
force-pushed
the
public-byte-order
branch
from
d294de4 to
99b3c03
Compare
fintelia
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we already provide a byte order for the decoder, there was no real use for this struct and information other than hand-coded loops. Modifying the byte order of byte-encoded values is used internally but the raw reader interfaces may require it to be handled by downstream code. This provides a basic interface for doing so.
This moves the struct to
tags,exposing a public export in decoder instead(turns out, we never exported the struct, so no need for this compatibility). Overall, de-emphasize the role ofEndianReadersince any bulk operation is much more efficient than the one-by-one byte order correct that it provides. I want to get rid of it at some point.