Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Implement the encoder's `TiffValue` trait for the tags commonly defined and represented as separate types in our own code. We don't tie the tag for an entry of these to the value type (yet). This lets us keep the trait exactly as-is and we avoid unnecessary churn. We can always add a separate trait on top.
197g
force-pushed
the
tiff-value-for-tags
branch
from
99490b8 to
fee650d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the encoder's
TiffValuetrait for the tags commonly defined and represented as separate types in our own code. We don't tie the tag for an entry of these to the value type (yet). This lets us keep the trait exactly as-is and we avoid unnecessary churn. We can always add a separate trait on top.