-
Notifications
You must be signed in to change notification settings - Fork 18
CI & deps: add Python 3.11–3.13, support urllib3 <3 (incl. v2) #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahnv
wants to merge
25
commits into
master
Choose a base branch
from
chore/urllib3-2x-compat-py36-38
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add env-marked pins: - Py>=3.9: requests>=2.32.2, urllib3!=2.0.0,<3 - 3.7–3.8: requests<2.32, urllib3<2 - 3.6: requests<2.28, urllib3<2 - Bump requests-toolbelt to >=1.0.0 - README: document per-Python resolver behavior - CI: matrix runs both urllib3<2 and urllib3>=2 on appropriate Pythons Refs: - Requests now requires Python >=3.9; 2.32.0/2.32.1 yanked (start at 2.32.2). - urllib3 2.x requires Python >=3.9. - requests-toolbelt 1.0.0 aligns with urllib3 2.x.
473d132
to
d5dd9b0
Compare
b3a8efc
to
bfc4cb1
Compare
bfc4cb1
to
53e6aaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our CI, test fixtures, and dependency constraints to support newer Python and
urllib3
versions while keeping compatibility with older runtimes. It also improves our GitHub Actions workflows and corrects several test mocks to align with real API behavior.What’s changed
GitHub Actions
ubuntu-22.04
and upgrade actions toactions/checkout@v5
andactions/setup-python@v5
.urllib3
lines tested via matrix:lt2
→ installsurllib3<2
(for 3.7/3.8 compatibility).ge2
→ installsurllib3!=2.0.0,<3
(tests v2 and future <3).ge2
on Python 3.7 and 3.8, becauseurllib3>=2
does not support Python 3.7 or 3.8.build
job runs tests across the matrix.release
job (Python 3.12) prepares build tooling (setuptools
,wheel
,twine
).Test Changes
content_type="application/json"
where appropriate."Content-Type"
headers from test setups.204
responses; add explicitcontent_type
where the client inspects headers."text/plain, application/json"
to"application/json"
.Purpose of Changes
urllib3
v2 while allowing v1 keeps broad compatibility (<3
).Compatibility
urllib3<3
and adjustsrequests
per Python version.urllib3<2
.