refactor initialization errors and add tests

Author: Jay Parekh

lib/imagekit/constants/errors.rb

@@ -69,3 +69,9 @@
                        'help': "Please pass two pHash values",}
 UNEQUAL_STRING_LENGTH = {'message': "Unequal pHash string length",
                          'help': "For distance calculation, the two pHash strings must have equal length",}
+
+MISSING_PRIVATE_KEY = "ImageKit private key missing"
+
+MISSING_PUBLIC_KEY = "ImageKit public key missing"
+
+MISSING_URL_ENDPOINT = "ImageKit URL Endpoint missing. Default URL Endpoint: https://ik.imagekit.io/<YOUR_IMAGEKIT_ID>/"

lib/imagekit/imagekit.rb

@@ -18,13 +18,13 @@ class ImageKitClient
     def initialize(private_key, public_key, url_endpoint, transformation_pos = nil, options = nil)
 
       unless(private_key.is_a?(String) && private_key.to_s.strip.length != 0)
-        raise ArgumentError, "ImageKit private key must be a valid, non-blank string"
+        raise ArgumentError, MISSING_PRIVATE_KEY
       end
       unless(public_key.is_a?(String) && public_key.to_s.strip.length != 0)
-        raise ArgumentError, "ImageKit public key must be a valid, non-blank string"
+        raise ArgumentError, MISSING_PUBLIC_KEY
       end
       unless(url_endpoint.is_a?(String) && url_endpoint.to_s.strip.length != 0)
-        raise ArgumentError, "ImageKit URL Endpoint should be valid, non-blank string"
+        raise ArgumentError, MISSING_URL_ENDPOINT
       end
 
       @private_key = private_key

test/imagekit/imagekit_test.rb

@@ -4,18 +4,46 @@
 
 RSpec.describe "FileUploadTest" do
 
-    it "test_initialization_with_parameters_missing" do
+    it "test_initialization_with_private_key_missing" do
       request_obj = double
       expect {
         ImageKit::ImageKitClient.new("  ", PUBLIC_KEY, URL_ENDPOINT)
-    }.to raise_error(ArgumentError)
+    }.to raise_error(ArgumentError, MISSING_PRIVATE_KEY)
     end
 
-    it "test_initialization_with_non_string_parameters" do
+    it "test_initialization_with_non_string_private_key" do
       request_obj = double
       expect {
         ImageKit::ImageKitClient.new({RANDOM: "RANDOM"}, PUBLIC_KEY, URL_ENDPOINT)
-    }.to raise_error(ArgumentError)
+    }.to raise_error(ArgumentError, MISSING_PRIVATE_KEY)
+    end
+
+    it "test_initialization_with_public_key_missing" do
+      request_obj = double
+      expect {
+        ImageKit::ImageKitClient.new(PRIVATE_KEY, "   ", URL_ENDPOINT)
+    }.to raise_error(ArgumentError, MISSING_PUBLIC_KEY)
+    end
+
+    it "test_initialization_with_non_string_public_key" do
+      request_obj = double
+      expect {
+        ImageKit::ImageKitClient.new(PRIVATE_KEY, {RANDOM: "RANDOM"}, URL_ENDPOINT)
+    }.to raise_error(ArgumentError, MISSING_PUBLIC_KEY)
+    end
+
+    it "test_initialization_with_url_endpoint_missing" do
+      request_obj = double
+      expect {
+        ImageKit::ImageKitClient.new(PRIVATE_KEY, PUBLIC_KEY, "  ")
+    }.to raise_error(ArgumentError, MISSING_URL_ENDPOINT)
+    end
+
+    it "test_initialization_with_non_string_url_endpoint" do
+      request_obj = double
+      expect {
+        ImageKit::ImageKitClient.new(PRIVATE_KEY, PUBLIC_KEY, {RANDOM: "RANDOM"})
+    }.to raise_error(ArgumentError, MISSING_URL_ENDPOINT)
     end
 
     it "test_upload_with_valid_expected_success" do