Skip to content

Commit abf085e

Browse files
Jay ParekhJay Parekh
authored andcommitted
refactor initializing parameters check
1 parent b7f7c71 commit abf085e

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

lib/imagekit/imagekit.rb

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,15 @@ class ImageKitClient
1616
attr_reader :file
1717

1818
def initialize(private_key, public_key, url_endpoint, transformation_pos = nil, options = nil)
19-
20-
unless(private_key.is_a?(String) && public_key.is_a?(String) && url_endpoint.is_a?(String))
21-
raise ArgumentError, "ImageKit Parameters should be valid string"
19+
20+
unless(private_key.is_a?(String) && private_key.to_s.strip.length != 0)
21+
raise ArgumentError, "ImageKit private key must be a valid, non-blank string"
22+
end
23+
unless(public_key.is_a?(String) && public_key.to_s.strip.length != 0)
24+
raise ArgumentError, "ImageKit public key must be a valid, non-blank string"
2225
end
23-
24-
unless(private_key.to_s.strip.length != 0 && public_key.to_s.strip.length != 0 && url_endpoint.to_s.strip.length != 0)
25-
raise ArgumentError, "ImageKit Parameters cannot be blank"
26+
unless(url_endpoint.is_a?(String) && url_endpoint.to_s.strip.length != 0)
27+
raise ArgumentError, "ImageKit URL Endpoint should be valid, non-blank string"
2628
end
2729

2830
@private_key = private_key

0 commit comments

Comments
 (0)