fix avatar and display name on direct conversation#218
Open
fvh-P wants to merge 2 commits intoimas:imastodonfrom
Open
fix avatar and display name on direct conversation#218fvh-P wants to merge 2 commits intoimas:imastodonfrom
fvh-P wants to merge 2 commits intoimas:imastodonfrom
Conversation
fvh-P
added
priority high
rinsuki
reviewed
May 28, 2019
Co-Authored-By: rinsuki <428rinsuki+git@gmail.com>
Member
|
バージョンアップでDM一覧は一新されたのでたぶん不要になったんじゃないかと思います |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #217
mastodon#9190
mastodon#10047
なお、上記2つによって「DMカラムは会話の最後が誰であっても相手のアバターと名前を表示する」仕様になったらしいので、これをどうするかは要検討でしょうか。
TwitterのDM一覧画面も常に相手のアイコンだからということでこの仕様になったみたいですが、MastodonではDMは他のカラムと同じインタフェースなので齟齬が生じているように見えますよね。