Fix auto-generated host name collisions with existing hosts#905
Draft
Fix auto-generated host name collisions with existing hosts#905
Conversation
When creating a host with an auto-generated name (e.g. `mng c @.modal`), the name was generated randomly without checking against existing hosts, which could produce collisions. Now discovers existing hosts on the provider first and retries name generation until a unique name is found. Fixed-name providers (like local, which always returns "localhost") are detected by observing that get_host_name returns the same value on retry, and the name is accepted as-is since such providers reuse hosts by design. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a host with an auto-generated name (e.g.
mng c @.modal), the name was generated randomly without checking against existing hosts, which could produce collisions. Now discovers existing hosts on the provider first and retries name generation until a unique name is found.Fixed-name providers (like local, which always returns "localhost") are detected by observing that get_host_name returns the same value on retry, and the name is accepted as-is since such providers reuse hosts by design.