Fix missing exit code check for streaming prepare command#42
Conversation
|
Vet found 4 issues. [documentation_implementation_mismatch] (severity 3/5) (confidence 0.95) The doc example for [documentation_implementation_mismatch] (severity 3/5) (confidence 0.95) The src/provider.rs:426 [documentation_implementation_mismatch] (severity 3/5) (confidence 0.95) The doc example for src/connector.rs:423 [test_coverage] (severity 2/5) (confidence 0.85) The new |
The streaming version of run_stream() did not return exit code information, so the prepare command in DefaultProvider would proceed even if the command failed with non-zero exit code. Changes: - Add ExitCode(i32) variant to OutputLine enum - Modify ShellConnector::run_stream() to yield exit code after stdout/stderr complete - Check exit code in DefaultProvider::from_config() and return ProviderError::ExecFailed if prepare command fails - Handle new ExitCode variant in output callbacks - Add tests for run_stream exit code behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aa12999 to
fc2a6db
Compare
|
Vet found 3 issues. [correctness_syntax_issues] (severity 3/5) (confidence 0.95) The src/connector.rs:179 [documentation_implementation_mismatch] (severity 3/5) (confidence 0.97) The docstring for the src/orchestrator/runner.rs:73 [correctness_syntax_issues] (severity 3/5) (confidence 0.95) The |
The streaming version of run_stream() did not return exit code information, so the prepare command in DefaultProvider would proceed even if the command failed with non-zero exit code.
Changes:
🤖 Generated with Claude Code