Factor out sandbox creation from orchestrator#44
Merged
Conversation
Sandboxes are now created upfront via SandboxPool::populate() and passed to the orchestrator. The orchestrator zips sandboxes with batches 1:1 (with an assert to verify they match). Changes: - Add SandboxPool::populate() - creates sandboxes concurrently using try_join_all for parallel creation with fail-fast behavior - Change Orchestrator to take SandboxPool directly (no Mutex needed) - Change type parameter from P: SandboxProvider to S: Sandbox - Simplify Orchestrator::new() - no longer needs provider or copy_dirs - Update main.rs to pre-populate pool before running orchestrator - Sandboxes are terminated at the end of run_with_tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Vet found 1 issue. src/orchestrator.rs:21 [documentation_implementation_mismatch] (severity 2/5) (confidence 0.85) The ARCHITECTURE.md file is listed as a required read in AGENTS.md ('You must read README.md, DESIGN.md, ARCHITECTURE.md, and STYLE_GUIDE.md before making changes'), and the orchestrator module's doc comments describe the architecture. The doc comment at the top of orchestrator.rs still shows the old architecture diagram with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SandboxPool::populate()before test execution (fail-fast on creation errors)Orchestratorto takeS: Sandboxinstead ofP: SandboxProvider(no longer creates sandboxes)Test plan
cargo fmt --checkpassescargo clippypassescargo nextest runpasses🤖 Generated with Claude Code