-
Notifications
You must be signed in to change notification settings - Fork 9
Add functionality to get python objects created during string cmd #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to get python objects created during string cmd #101
Conversation
|
@danielwolff1 I think this should be pretty much exactly what we talked about a while ago. I needed this and I think this PR should provide a general working implementation, I am looking forward to your review. I decided to only wrap string commands, as "pure" python commands usually return the relevant created geometry. If we also want to allow a similar functionality there, I would do that in a follow up PR. |
danielwolff1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great addition. This is much more advanced than the solution that I came up with since it tracks all geometric entities, I really love it and can't wait to see it merged soon! 😊
I just had three small questions, but we can also discuss in person after your vacation 😄
bb34346 to
6aa8e36
Compare
6aa8e36 to
0ad0799
Compare
|
@danielwolff1 this should add the changes we talked about offline. Now we have two functions with unique signatures, that should ease their usage and avoid confusion. |
danielwolff1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adapting the implementation, this looks good from my point of view and we can merge this right now, I can't wait to see this functionality in cubitpy! 🥳
0ad0799 to
ac9c20c
Compare
This PR adds the functionality to get python objects created during string cmd. One can now execute a string command with the wrapper
cmd_returnand this function returns the created geometry objects.