-
Notifications
You must be signed in to change notification settings - Fork 9
Modify solid-to-solid contact BC and add new test #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify solid-to-solid contact BC and add new test #95
Conversation
isteinbrecher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @danielwolff1 , I only have some minor comments.
@knarfnitram this will break the "old" approach of defining surface-to-surface contact, I think you might be the only one using that. If you need it we can keep the solid_to_solid_surface_contact enum as a legacy enum.
Also add some small improvements to the readme
438d96c to
ad9b01a
Compare
Outset
When trying to run a 2D contact simulation I realized that there is currently no BC enum for this case implemented.
What was changed?
In this PR, I implemented a potential solution, suggesting to rename the existing enum
solid_to_solid_surface_contactsimply tosolid_to_solidcontact, since we're anyway checking for the dimensionality of the geometric entities in contact before adding the BC string to the 4C input file.Was the new implementation tested?
I adapted the unit test for surface-to-surface contact accordingly and added a new unit-test for curve-to-curve contact. All unit tests passed on my local machine.
Sidequests
I noticed that parts of the
README.mdwhere outdated / not accurate, so I adapted them accordingly as well :)