Skip to content

Conversation

@danielwolff1
Copy link
Contributor

Outset

When trying to run a 2D contact simulation I realized that there is currently no BC enum for this case implemented.

What was changed?

In this PR, I implemented a potential solution, suggesting to rename the existing enum solid_to_solid_surface_contact simply to solid_to_solid contact, since we're anyway checking for the dimensionality of the geometric entities in contact before adding the BC string to the 4C input file.

Was the new implementation tested?

I adapted the unit test for surface-to-surface contact accordingly and added a new unit-test for curve-to-curve contact. All unit tests passed on my local machine.

Sidequests

I noticed that parts of the README.md where outdated / not accurate, so I adapted them accordingly as well :)

@danielwolff1 danielwolff1 self-assigned this Jul 18, 2025
@danielwolff1 danielwolff1 temporarily deployed to cubit_secrets_untrusted July 18, 2025 09:36 — with GitHub Actions Inactive
Copy link
Collaborator

@isteinbrecher isteinbrecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @danielwolff1 , I only have some minor comments.

@knarfnitram this will break the "old" approach of defining surface-to-surface contact, I think you might be the only one using that. If you need it we can keep the solid_to_solid_surface_contact enum as a legacy enum.

@isteinbrecher isteinbrecher temporarily deployed to cubit_secrets_untrusted July 18, 2025 10:41 — with GitHub Actions Inactive
@danielwolff1 danielwolff1 had a problem deploying to cubit_secrets_untrusted July 18, 2025 11:14 — with GitHub Actions Failure
@danielwolff1 danielwolff1 force-pushed the generalize-solid-to-solid-contact-bc branch from 438d96c to ad9b01a Compare July 18, 2025 11:30
@danielwolff1 danielwolff1 had a problem deploying to cubit_secrets_untrusted July 18, 2025 11:30 — with GitHub Actions Failure
@danielwolff1 danielwolff1 temporarily deployed to cubit_secrets_untrusted July 18, 2025 12:07 — with GitHub Actions Inactive
@isteinbrecher isteinbrecher temporarily deployed to cubit_secrets_untrusted July 18, 2025 12:17 — with GitHub Actions Inactive
@isteinbrecher isteinbrecher merged commit e8db3d5 into imcs-compsim:main Jul 18, 2025
2 checks passed
@danielwolff1 danielwolff1 deleted the generalize-solid-to-solid-contact-bc branch July 18, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants