-
Notifications
You must be signed in to change notification settings - Fork 9
Add yaml with exo export #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yaml with exo export #98
Conversation
|
@m-frey this might be interesting for you since we talked about it yesterday :) |
isteinbrecher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution @danielwolff1, this is surely a very useful feature!
Co-authored-by: Ivo Steinbrecher <[email protected]>
danielwolff1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the swift review! I'm going to address all your points and then we can have a chat to clarify the remaining open points.
isteinbrecher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional effort @danielwolff1, this looks good to me! If we want we can add the functionality for multi field input files (e.g., FSI) in a follow up PR.
I now adapted the implementation and implemented a small test case to support the export of multiple fields. However, in the unit test, I decided not to replicate the correct definition of the boundary conditions from the 3D FSI tutorial, as the additional statements for creating the BCs would just blow up the test method and not really add anything, since the creation of the geometry section is independent of the creation of the boundary sections of the input files. Moreover, the latter are already tested in other functions. If you are fine with my proposal, this can be merged, otherwise I can also still adapt the test accordingly. |
isteinbrecher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danielwolff1 for these changes, very nice that we can now use the new 4C input features with directly reading exo files.
|
Thanks for the great review process and for approving, I'm going to merge now! 🚀 |
In this PR, I implemented a method to export the mesh in exo format while dumping the .yaml input file.
When using the new method
dump_with_exo_mesh(),cubitpywill automatically attach theXYZ GEOMETRYsection to the yaml input file as well as omit the lengthy topology information, which will instead be inferred from the nodesets within 4C when reading in the exo mesh.To fully enable this feature, I need to know which problems people at the institute are working with, in order to enable the output of the respective "GEOMETRY" section. Currently supported
PROBLEMTYPEs areFluidStructurebut more can be added if needed, by extending the
problem_to_geometry_dictinside theadd_problem_geometry_section()function.