Skip to content

Conversation

@Talljoe
Copy link

@Talljoe Talljoe commented Aug 25, 2023

Description

When setting srcset_options on a breakpoint it was not being used by Tag::srcset instead defaulting
to the generic srcset_options (if provided). This change makes srcset used the options passed
to the method instead of the class-instance variables.

Checklist

  • Read the contributing guidelines.
  • Each commit follows the Conventional Commit spec format.
  • Update the readme (if applicable).
  • Update or add any necessary API documentation (if applicable)
  • All existing unit tests are still passing (if applicable).
  • Add some steps so we can test your bug fix or feature (if applicable).
  • Add new passing unit tests to cover the code introduced by your PR (if applicable).
  • Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
  • If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

@Talljoe Talljoe requested a review from a team as a code owner August 25, 2023 00:17
@commit-lint
Copy link

commit-lint bot commented Aug 25, 2023

Bug Fixes

  • fix issue where breakpoit srcset_options weren't being used (5a446af)

Contributors

Talljoe

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@Talljoe Talljoe changed the title fix: fix issue where breakpoit srcset_options weren't being used fix: fix issue where breakpoint srcset_options weren't being used Aug 25, 2023
@jtarchie
Copy link

jtarchie commented Sep 4, 2025

This may not be the only place. This line also implies the srcset will always be overridden, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants