Open
Conversation
| } | ||
| } | ||
|
|
||
| } |
Member
There was a problem hiding this comment.
could you use the source code from the latest deployed docs? That has better handling for gallery intent, doesn't use the deprecated getExternalStorageDirectory, and also doesn't have un-needed permission handling.
| android:layout_height="match_parent" | ||
| android:layout_weight="25"/> | ||
| </LinearLayout> | ||
| </RelativeLayout> No newline at end of file |
Member
There was a problem hiding this comment.
not needed in this sample?
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/> | ||
| <uses-permission android:name="android.permission.INTERNET"/> | ||
|
|
||
| <protected-broadcast android:name="android.intent.action.MEDIA_MOUNTED" /> |
Member
There was a problem hiding this comment.
why is this broadcast needed? 😅
|
|
||
| // We hijack internalLoadBitmapCache to know when it's time to load the cache | ||
| override fun internalLoadBitmapCache(pixelSize: Long, sync: Boolean): Boolean { | ||
| if (!isClickCacheLoading && clickAreaCache == BitmapFactoryUtils.NOTHING_BITMAP) { |
Member
There was a problem hiding this comment.
can we add a check for !sync here since this is not needed in the case of exporting..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.