Skip to content

Conversation

@11bit
Copy link
Collaborator

@11bit 11bit commented Dec 17, 2025

Closes #66

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the flip option to imgproxy-js-core, allowing users to flip images horizontally and/or vertically. The implementation follows the established patterns used by other boolean-like options in the codebase.

Key Changes:

  • Adds flip option type definitions with support for boolean-like values (true, false, 1, 0, "t", "f")
  • Implements flip option builder that generates the fl:horizontal:vertical URL format
  • Includes comprehensive test coverage for various value types and edge cases

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/types/flip.ts Defines FlipOptions type and FlipOptionsPartial interface with horizontal/vertical properties supporting boolean-like values
src/options/flip.ts Implements test and build functions for flip option, including shorthand fl support
tests/optionsBasic/flip.test.ts Comprehensive test suite covering various input types, defaults, and both flip/fl shorthands
src/types/index.ts Integrates FlipOptionsPartial into the main Options type
src/options/index.ts Exports flip module for public API access
.changeset/brown-mangos-fetch.md Documents the feature addition as a minor version change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Dec 17, 2025

@11bit I've opened a new pull request, #74, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Dec 17, 2025

@11bit I've opened a new pull request, #75, to work on those changes. Once the pull request is ready, I'll request review from you.

@11bit 11bit merged commit ee3bf50 into main Dec 17, 2025
1 check passed
@11bit 11bit deleted the flip branch December 17, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usage docs of imgproxy have been updated

2 participants