feat: sql-tools overrides #19796
Merged
feat: sql-tools overrides #19796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
feat/sql-tools-overrides
branch
from
7b0f268 to
542ae74
Compare
danieldietzler
approved these changes
Jul 7, 2025
Comment on lines
6
to
11
| const result = await sql | ||
| .raw<{ | ||
| name: string; | ||
| value: string; | ||
| }>(`SELECT name, value FROM "${ctx.overrideTableName}"`) | ||
| .execute(db); |
There was a problem hiding this comment.
I don't think you need a raw query here. Dynamic tables released in 0.28.2 https://github.com/kysely-org/kysely/releases/tag/0.28.2 should be exactly for this use case I believe.
jrasm91
force-pushed
the
feat/sql-tools-overrides
branch
from
542ae74 to
ad420d8
Compare
jrasm91
force-pushed
the
feat/sql-tools-overrides
branch
from
ad420d8 to
9f867e2
Compare
zackpollard
approved these changes
Jul 8, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable synchronization for triggers, functions, and indexes with expressions via overrides (keep track of the SQL create statements in a metadata table -
migration_overrides).