Skip to content

feat(web): Add to Multiple Albums #20072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
41a0674
Multi add to album picker:
xCJPECKOVERx Jul 21, 2025
ebb812b
initial addToAlbums endpoint
xCJPECKOVERx Jul 21, 2025
4578c0a
- fix endpoint
xCJPECKOVERx Jul 21, 2025
713a962
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 21, 2025
f129aaf
- update return type
xCJPECKOVERx Jul 21, 2025
9bedaa2
- simplify return dto
xCJPECKOVERx Jul 21, 2025
e7c119a
- fix returns
xCJPECKOVERx Jul 21, 2025
3946bfd
- update i18n
xCJPECKOVERx Jul 21, 2025
a7db5c1
- checks
xCJPECKOVERx Jul 22, 2025
9bbd583
- correct successId count
xCJPECKOVERx Jul 22, 2025
5c2e0f3
tests
xCJPECKOVERx Jul 22, 2025
8904334
foromat
xCJPECKOVERx Jul 22, 2025
144ac6b
refactor
xCJPECKOVERx Jul 22, 2025
a47eccb
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 22, 2025
c0be70c
- update successful add message to included total attempted
xCJPECKOVERx Jul 22, 2025
db74a36
- fix web test
xCJPECKOVERx Jul 22, 2025
14a2456
- fix open-api
xCJPECKOVERx Jul 22, 2025
a37ba2a
- fix imports to resolve checks
xCJPECKOVERx Jul 22, 2025
9ee7dc6
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 24, 2025
2f59ebf
- PR suggestions
xCJPECKOVERx Jul 24, 2025
6ee48f7
open-api
xCJPECKOVERx Jul 24, 2025
b77a5c7
refactor addAssetsToAlbums
xCJPECKOVERx Jul 24, 2025
845db94
refactor it again
xCJPECKOVERx Jul 25, 2025
860fc03
- fix error returns and tests
xCJPECKOVERx Jul 25, 2025
b6cc793
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 25, 2025
37e1209
- swap icon for IconButton
xCJPECKOVERx Jul 25, 2025
a0fcbf3
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 27, 2025
383da33
open-api
xCJPECKOVERx Jul 27, 2025
dff2db6
- Cleanup multi-select button to match Thumbnail
xCJPECKOVERx Jul 30, 2025
e481951
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Jul 30, 2025
08da570
merge and openapi
xCJPECKOVERx Jul 30, 2025
35f89ad
- remove onclick from icon element
xCJPECKOVERx Jul 30, 2025
eeec4a5
- fix double onClose call with keyboard shortcuts
xCJPECKOVERx Jul 30, 2025
e6acf76
Merge branch 'main' into feat/add-to-album-multi
xCJPECKOVERx Aug 10, 2025
db71e10
- spelling and formatting
xCJPECKOVERx Aug 10, 2025
c772a2a
- open-api
xCJPECKOVERx Aug 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
"add_to_album": "Add to album",
"add_to_album_bottom_sheet_added": "Added to {album}",
"add_to_album_bottom_sheet_already_exists": "Already in {album}",
"add_to_album_toggle": "Toggle selection for {album}",
"add_to_albums": "Add to albums",
"add_to_shared_album": "Add to shared album",
"add_url": "Add URL",
"added_to_archive": "Added to archive",
Expand Down Expand Up @@ -497,7 +499,9 @@
"assets": "Assets",
"assets_added_count": "Added {count, plural, one {# asset} other {# assets}}",
"assets_added_to_album_count": "Added {count, plural, one {# asset} other {# assets}} to the album",
"assets_added_to_albums_count": "Added {assetCount} of {assetTotal} assets to {albumCount} of {albumTotal} albums",
"assets_cannot_be_added_to_album_count": "{count, plural, one {Asset} other {Assets}} cannot be added to the album",
"assets_cannot_be_added_to_albums": "{count, plural, one {Asset} other {Assets}} cannot be added to any of the albums",
"assets_count": "{count, plural, one {# asset} other {# assets}}",
"assets_deleted_permanently": "{count} asset(s) deleted permanently",
"assets_deleted_permanently_from_server": "{count} asset(s) deleted permanently from the Immich server",
Expand All @@ -514,6 +518,7 @@
"assets_trashed_count": "Trashed {count, plural, one {# asset} other {# assets}}",
"assets_trashed_from_server": "{count} asset(s) trashed from the Immich server",
"assets_were_part_of_album_count": "{count, plural, one {Asset was} other {Assets were}} already part of the album",
"assets_were_part_of_albums_count": "{count, plural, one {Asset was} other {Assets were}} already part of the albums",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you just... duplicated this key from the line above? 👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

album -> albums lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn it I'm blind 😅

"authorized_devices": "Authorized Devices",
"automatic_endpoint_switching_subtitle": "Connect locally over designated Wi-Fi when available and use alternative connections elsewhere",
"automatic_endpoint_switching_title": "Automatic URL switching",
Expand Down
4 changes: 4 additions & 0 deletions mobile/openapi/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions mobile/openapi/lib/api.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

67 changes: 67 additions & 0 deletions mobile/openapi/lib/api/albums_api.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions mobile/openapi/lib/api_client.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions mobile/openapi/lib/api_helper.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

111 changes: 111 additions & 0 deletions mobile/openapi/lib/model/albums_add_assets_dto.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading