fix: avoid unnecessary writes to system metadata repository #20538
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the server in a secondary, read-only role against a PostgreSQL read-only replica, the bootstrap process currently attempts to unconditionally write the media location to the metadata repository. This leads to the following error:
This PR updates the bootstrap logic to avoid unnecessary writes by writing MediaLocation only if it is missing or has changed compared to the current runtime-detected value.
This change make the bootstrap process safe to run in read-only environments.
How Has This Been Tested?
Checklist:
src/services/
uses repositories implementations for database calls, filesystem operations, etc.src/repositories/
is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/
)