fix: Any asset update disables isFavorite action in GUI. Only owner of asset in album should see favorited image.

[pwojtaszko]

Fixed: Any asset update disables isFavorite action in GUI. Only owner of asset in album should see favorited image.

Description

I was trying to fix issue from link below.
Other than that I noticed that /buckets request was returning isFavorite: true for non asset owners inside album.
There was fix for that long time ago: #7580, but it looks like /buckets request was introduced without that workaround.
Issue from #19089 was caused by previous workaround. I fixed that by passing userId required for recognizing owner.

Fixes # (issue)

How Has This Been Tested?

Main fix:

1. I added photo to favorite -> Favorite icon is enabled
2. I modified photo location
3. Favorite was not reset

Additional fix:

1. I added assets to album with user A and user B
2. I favorited owned assets using user A and user B
3. Both users see only their own favorited assets, they're not able to see other person favorite assets and are not able to favorite them.

Screenshots (if appropriate)

User B only asset is:

Before fix:
User A:

User B:

After fix:
User A:

User B:

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable
• I have no unrelated changes in the PR.
• I have confirmed that any new dependencies are strictly necessary.
• I have written tests for new code (if applicable)
• I have followed naming conventions/patterns in the surrounding code
• All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
• All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

[github-actions]

Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label.

[pwojtaszko]

Closing for now due to test issues.

[pwojtaszko]

Reopened due to issues with local tests setup.

@alextran1502, could you please check if changes even make sense? In the meantime I'm trying to fix my setup so I'll be able to run server tests.